Bugfix/issue 1033 lubridate::here()#1044
Open
skolenik wants to merge 2 commits into
Open
Conversation
…und.Rmd here vs lubridate::here() -> stats vs. dplyr::filter()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1033 #1033 points out to
lubridate::here()being removed from the package. The example in Sec 10.2.1 https://r-pkgs.org/dependencies-mindset-background.html#sec-dependencies-namespace-motivation got obsolete. I am providing a replacement withdplyr::filter()although I recognize that it has limitations: it does not really how the package load sequence affects the search path.(Some easy alternatives can be cooked up with
tidylogthat provides additional output to manydplyrverbs.)