Feat/super admin batch roles #66
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. I think you didn't accept the incoming changes when you merged main -> your branch, make sure to use what main has for these
Collaborator
There was a problem hiding this comment. sorry, look at the lost comment to see what im talking about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. Request payload is swapped but should be fine: The response payload should be: you currently have: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "errors" | ||
| "net/http" | ||
|
|
||
| "github.com/hackutd/portal/internal/store" | ||
| ) | ||
|
|
||
| type BatchUpdateRolesPayload struct { | ||
| UserIDs []string `json:"user_ids" validate:"required,min=1,max=50,dive,uuid"` | ||
| Role store.UserRole `json:"role" validate:"required,oneof=hacker admin"` | ||
| } | ||
|
|
||
| type BatchUpdateRolesResponse struct { | ||
| Users []*store.User `json:"users"` | ||
| } | ||
|
|
||
| // batchUpdateRolesHandler updates the role for a batch of users | ||
| // | ||
| // @Summary Batch update user roles (Super Admin) | ||
| // @Description Updates the role for up to 50 users. Cannot modify own role. | ||
| // @Tags superadmin | ||
| // @Accept json | ||
| // @Produce json | ||
| // @Param payload body BatchUpdateRolesPayload true "User IDs and target role" | ||
| // @Success 200 {object} BatchUpdateRolesResponse | ||
| // @Failure 400 {object} object{error=string} | ||
| // @Failure 401 {object} object{error=string} | ||
| // @Failure 403 {object} object{error=string} | ||
| // @Failure 500 {object} object{error=string} | ||
| // @Security CookieAuth | ||
| // @Router /superadmin/users/role [patch] | ||
| func (app *application) batchUpdateRolesHandler(w http.ResponseWriter, r *http.Request) { | ||
| var req BatchUpdateRolesPayload | ||
| if err := readJSON(w, r, &req); err != nil { | ||
| app.badRequestResponse(w, r, err) | ||
| return | ||
| } | ||
|
|
||
| if err := Validate.Struct(req); err != nil { | ||
| app.badRequestResponse(w, r, err) | ||
|
Collaborator
There was a problem hiding this comment. give a proper error message, i thought you didn't implement this feature |
||
| return | ||
| } | ||
|
|
||
| caller := getUserFromContext(r.Context()) | ||
| if caller == nil { | ||
| app.internalServerError(w, r, errors.New("user not in context")) | ||
| return | ||
| } | ||
|
|
||
| for _, id := range req.UserIDs { | ||
| if id == caller.ID { | ||
| app.badRequestResponse(w, r, errors.New("cannot modify your own role")) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| users, err := app.store.Users.BatchUpdateRoles(r.Context(), req.UserIDs, req.Role) | ||
| if err != nil { | ||
| app.internalServerError(w, r, err) | ||
| return | ||
| } | ||
|
|
||
| if len(users) != len(req.UserIDs) { | ||
| app.badRequestResponse(w, r, errors.New("one or more user IDs do not exist")) | ||
| return | ||
| } | ||
|
|
||
| if err := app.jsonResponse(w, http.StatusOK, BatchUpdateRolesResponse{Users: users}); err != nil { | ||
| app.internalServerError(w, r, err) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is like a 95% chance changing the allowedOrigins is not allowed, you shouldn't have to edit configs
Check w/ Caleb