Open
Conversation
…ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
…iles, like the poseidon directory
…iles, like the poseidon directory
…. It fails to mention certain aspects like ‘transact’, for example
… be the best approach. While it can be utilized for initial generation, the final versions should be committed to the repository
…ption. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments. - The usage of several formal verification annotations is noted, but nothing is checked against. - The test cases could benefit from being more comprehensive.
…comments please add. Additionally, the test suite requires more explanatory comments
…ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
…ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
…ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.