fix: Fix one captcha per container issue #250
Conversation
| if (this._hcaptcha) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Are we sure this is correct? This check only validates whether the API has loaded within the current window context.
If you continue to follow the logic of this function, we then use this specific later to determine if we should even render hCaptcha or load the API. If the API is loaded, then the render function will be called. From here the render function checks if a captcha already exists by referencing the id of it.
There was a problem hiding this comment.
I also thought if it's safer to use state.captchaId
in general, this logic works as expected, as this._hcaptcha is set only in componentDidMount, so renderCaptcha is still called
There was a problem hiding this comment.
it looks as the safe solution to me as it's the way to ensure that componentDidMount is called only once
we could actually use any other variable for that
also React.StrictMode calls componentDidMount twice only on dev mode, so it should be safe especially on prod
however, as the alternative, we could go with this PR: #251
please take a look
Relates to #189
Before
Screen.Recording.2025-02-06.at.15.28.52.mov
After
Screen.Recording.2025-02-06.at.15.30.00.mov