Skip to content

ENH: add musllinux images#18

Merged
takluyver merged 3 commits intoh5py:masterfrom
neutrinoceros:enh/musllinux
Aug 8, 2025
Merged

ENH: add musllinux images#18
takluyver merged 3 commits intoh5py:masterfrom
neutrinoceros:enh/musllinux

Conversation

@neutrinoceros
Copy link
Contributor

In support to h5py/h5py#2632

@neutrinoceros
Copy link
Contributor Author

/tmp/install_hdf5.sh: line 4: yum: command not found

I don't have time left to look into this today

@neutrinoceros
Copy link
Contributor Author

This is now based off #19

@neutrinoceros neutrinoceros changed the title ENH: add musllinux images ENH: add musllinux images Aug 7, 2025
@neutrinoceros neutrinoceros force-pushed the enh/musllinux branch 3 times, most recently from 6dff0de to 601334d Compare August 7, 2025 08:25
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Aug 7, 2025

note: templating docker files seems like a nice secondary goal here but I'm leaving it for after I get something working, to avoid premature optimization.

@neutrinoceros neutrinoceros marked this pull request as ready for review August 7, 2025 09:19
@takluyver
Copy link
Member

Out of interest, did you record what the error message from ldconfig in musllinux builds was? I thought that command was generally safe to run any time, effectively just updating some cache. 😕

templating docker files seems like a nice secondary goal here but I'm leaving it for after I get something working

I'd suggest we leave it as is, at least until our needs evolve further. There are 4 files of 9 lines each - I don't think deduplicating that is worth adding an extra layer of machinery. 🙂

LGTM

@takluyver takluyver merged commit 3539915 into h5py:master Aug 8, 2025
4 checks passed
@neutrinoceros
Copy link
Contributor Author

Out of interest, did you record what the error message from ldconfig in musllinux builds was?

Sorry, I didn't, but I recall it was not very informative, and didn't visibly have any connection to ldconfig. I only thought of trying to skip it because the comment that comes with seemed to indicate it might not always be necessary...

I'd suggest we leave it as is, at least until our needs evolve further. There are 4 files of 9 lines each - I don't think deduplicating that is worth adding an extra layer of machinery.

Yeah, I actually tried deduplicating it in #20 and re-considered when I realized we need these files to be version-tracked.

@neutrinoceros neutrinoceros deleted the enh/musllinux branch August 8, 2025 09:41
@takluyver
Copy link
Member

Fair enough, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants