Skip to content

Return with and heigh of the generated images #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2non merged 4 commits into from
Mar 30, 2022
Merged

Return with and heigh of the generated images #382

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5d91ce
Return with and heigh of the generated images
CarlSchwan Feb 11, 2022
270eeeb
Make mimetype support always return true
CarlSchwan Feb 22, 2022
9e4c26e
Add command line option to enable this feature
CarlSchwan Mar 14, 2022
234d1fe
refactor: remove deprecated X- prefix in response headers
h2non Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions controllers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@ func imageHandler(w http.ResponseWriter, r *http.Request, buf []byte, operation
// Expose Content-Length response header
w.Header().Set("Content-Length", strconv.Itoa(len(image.Body)))
w.Header().Set("Content-Type", image.Mime)
if image.Mime != "application/json" {
meta, err := bimg.Metadata(image.Body)
if err == nil {
w.Header().Set("X-Image-Width", strconv.Itoa(meta.Size.Width))
w.Header().Set("X-Image-Height", strconv.Itoa(meta.Size.Height))
}
}
if vary != "" {
w.Header().Set("Vary", vary)
}
Expand Down
3 changes: 2 additions & 1 deletion type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ func IsImageMimeTypeSupported(mime string) bool {
format = "svg"
}

return bimg.IsTypeNameSupported(format)
// Tmp hack to see if this fix an issue
return true // bimg.IsTypeNameSupported(format)
}

// ImageType returns the image type based on the given image type alias.
Expand Down