You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for using data.table! We noticed you are Depending on us and recently decided to strongly discourage downstream packages from doing so -- we think Imports is always better.
This PR attempts to make the migration from Depends to Imports for data.table.
If you have a strong reason for preferring Depends, we'd love to hear it over at our issue tracker:
data.table also defines .N as NULL and := to be a dummy function.
.N and := are done with non-standard evaluation within [.data.table -- we examine the expression and look specifically for these (and other) symbols and then interpret them within that context.
Moreover, in terms of inheritance, when .N is being used in your package, it's evaluated by [.data.table, the parent environment of which is the data.table package environment, where .N is defined as NULL by us.
So, the value you define in your package environment is (1) never seen by data.table and (2) not on the right inheritance path anyway -- the version in data.table will always be seen first.
Doing this is just a ruse to trick R CMD check into passing your package while using NSE variables :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for using
data.table! We noticed you areDepending on us and recently decided to strongly discourage downstream packages from doing so -- we thinkImportsis always better.This PR attempts to make the migration from Depends to Imports for
data.table.If you have a strong reason for preferring
Depends, we'd love to hear it over at our issue tracker:Rdatatable/data.table#3076