Exceptions thrown when building GWT's AST should include context#10080
Merged
niloc132 merged 2 commits intogwtproject:mainfrom Feb 16, 2025
Merged
Exceptions thrown when building GWT's AST should include context#10080niloc132 merged 2 commits intogwtproject:mainfrom
niloc132 merged 2 commits intogwtproject:mainfrom
Conversation
Several visit and endVisit methods were missing their try/catch wrapping to translate any exception that occurs, with context of the given JDT ast node where the error took place. Follow-up gwtproject#10065
niloc132
force-pushed
the
ast-builder-exception-test
branch
from
0d791d7 to
f39e689
Compare
Member
Author
|
This PR is much easier to review if you enable the "Hide whitespace" feature in the changes tab |
niloc132
force-pushed
the
ast-builder-exception-test
branch
from
02248b7 to
e2e66a7
Compare
vegegoku
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several visit and endVisit methods were missing their try/catch wrapping to translate any exception that occurs, with context of the given JDT ast node where the error took place.
Follow-up #10065