Conversation
|
failing test not related to this PR |
nlmod/gwf/surface_water.py
Outdated
There was a problem hiding this comment.
maybe good to get ahead of any further deprecations and use "cellid" for all grids?
dbrakenhoff
left a comment
dbrakenhoff
left a comment
There was a problem hiding this comment.
One comment, if we want a quick release it can be ignored, otherwise maybe good to improve it now.
|
I removed the references to 'cellids'. I also made a complete mess because I accidentally pushed everything to the dev branch, tried to revert it and partly succeeded. I think if we merge this everything will be fine. |
|
ok, will you merge it? I updated the nhi-gwo test in the dev-branch, so it will skip the test when a httperror is raised. |
| min_area_fraction=min_area_fraction, | ||
| geo_dataframe=True | ||
| **kwargs, | ||
| geo_dataframe=True**kwargs, |
There was a problem hiding this comment.
hmm, this does not look right
There was a problem hiding this comment.
Fixed in the dev-branch
3 participants
No description provided.