Skip to content

Empty lakeout column leads error in lake package construction #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdestombe merged 2 commits into from
Aug 6, 2025
Merged

Empty lakeout column leads error in lake package construction #502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb0090
Empty lakeout column leads error in lake package construction
bdestombe Aug 5, 2025
5acb369
Fixed newly introduced bug in lake.py
bdestombe Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions nlmod/gwf/lake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,8 @@ def lake_from_gdf(

lake_settings = [setting for setting in LAKE_KWDS if setting in gdf.columns]

if "lakeout" in gdf.columns:
outlets = []
outlet_no = 0
use_outlets = True
logger.debug("using lake outlets")
else:
use_outlets = False
noutlets = None
outlets = None
outlets = []
outlet_no = 0

fal = get_first_active_layer(ds).data

Expand Down Expand Up @@ -208,7 +201,7 @@ def lake_from_gdf(
iconn += 1

# add outlets to lake
if use_outlets and (not lake_gdf["lakeout"].isna().all()):
if "lakeout" in lake_gdf.columns and not lake_gdf["lakeout"].isna().all():
lakeout = _get_and_check_single_value(lake_gdf, "lakeout")
if isinstance(lakeout, str):
# when lakeout is a string, it represents the boundname
Expand Down Expand Up @@ -296,9 +289,6 @@ def lake_from_gdf(
[lakeno, "evaporation", evaporation_concentration]
)

if use_outlets:
noutlets = len(outlets)

if boundname_column is not None:
observations = {}
if isinstance(obs_type, str):
Expand All @@ -323,8 +313,8 @@ def lake_from_gdf(
observations=observations,
budget_filerecord=f"{pname}.bgt",
stage_filerecord=f"{pname}.hds",
noutlets=noutlets,
outlets=outlets,
noutlets=len(outlets) if outlets else None,
outlets=outlets if outlets else None,
pname=pname,
**kwargs,
)
Expand Down