Merged
Conversation
Collaborator
dbrakenhoff
commented
Jun 16, 2025
dbrakenhoff
commented
- Note that we are not sure whether this new layer contains the same waterlevel information as the previous one. This is something we will have to check with HHNK. Progress on that will be posted in issue HHNK data not reachable #465.
- Note that we are not sure whether this new layer contains the same waterlevel information as the previous one. This is something we will have to check with HHNK. Progress on that will be posted in issue #465.
Closed
…s defined - assumes config[waterboard][verify] is a url for an intermediate certificate - this certificate is downloaded and bundled with certifi and stored in a temporary file. - this file is passed on to requests.get() - this allows us to download HHNK data again
rubencalje
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.