Skip to content

deal with floating point issues #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrakenhoff merged 1 commit into from
Jun 11, 2025
Merged

deal with floating point issues #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions nlmod/dims/resample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
logger = logging.getLogger(__name__)


def get_xy_mid_structured(extent, delr, delc, descending_y=True):
def get_xy_mid_structured(extent, delr, delc, descending_y=True, tiny=1e-10):
"""Calculates the x and y coordinates of the cell centers of a structured grid.

Parameters
Expand All @@ -27,6 +27,9 @@ def get_xy_mid_structured(extent, delr, delc, descending_y=True):
descending_y : bool, optional
if True the resulting ymid array is in descending order. This is the
default for MODFLOW models. default is True.
tiny : float, optional
A small value (for floating point reasons) to check if the extent is valid.
The default is 1e-10.

Returns
-------
Expand All @@ -40,12 +43,12 @@ def get_xy_mid_structured(extent, delr, delc, descending_y=True):
raise TypeError("if delr is a number delc should be a number as well")

# check if extent is valid
if (extent[1] - extent[0]) % delr != 0.0:
if (extent[1] - extent[0]) % delr > tiny:
raise ValueError(
"invalid extent, the extent should contain an integer"
" number of cells in the x-direction"
)
if (extent[3] - extent[2]) % delc != 0.0:
if (extent[3] - extent[2]) % delc > tiny:
raise ValueError(
"invalid extent, the extent should contain an integer"
" number of cells in the y-direction"
Expand Down
Loading