Skip to content

Improve DSP and IC pkgs #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrakenhoff merged 2 commits into from
Jun 11, 2025
+14 −3
Merged

Improve DSP and IC pkgs #473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df34bb8
improve DSP and IC pkgs
dbrakenhoff May 29, 2025
2548a67
turn off warning for diffc
dbrakenhoff Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions nlmod/gwt/gwt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import numbers

import flopy
import xarray as xr

from ..dims import grid
from ..gwf.gwf import _dis, _disv, _set_record
Expand Down Expand Up @@ -128,12 +129,17 @@ def dsp(ds, gwt, **kwargs):
dsp package
"""
logger.info("creating mf6 DSP")
diffc = _get_value_from_ds_attr(
ds, "diffc", "dsp_diffc", value=kwargs.pop("diffc", None)
)
alh = _get_value_from_ds_attr(ds, "alh", "dsp_alh", value=kwargs.pop("alh", None))
ath1 = _get_value_from_ds_attr(
ds, "ath1", "dsp_ath1", value=kwargs.pop("ath1", None)
)
atv = _get_value_from_ds_attr(ds, "atv", "dsp_atv", value=kwargs.pop("atv", None))
dsp = flopy.mf6.ModflowGwtdsp(gwt, alh=alh, ath1=ath1, atv=atv, **kwargs)
dsp = flopy.mf6.ModflowGwtdsp(
gwt, diffc=diffc, alh=alh, ath1=ath1, atv=atv, **kwargs
)
return dsp


Expand Down Expand Up @@ -310,8 +316,13 @@ def ic(ds, gwt, strt, pname="ic", **kwargs):
ic package
"""
logger.info("creating mf6 IC")
if not isinstance(strt, numbers.Number):
strt = ds[strt].data
if isinstance(strt, numbers.Number):
logger.info("adding 'starting_conc' data array to ds")
ds["starting_conc"] = strt * xr.ones_like(ds["botm"])
ds["starting_conc"].attrs["units"] = "mNAP"
strt = "starting_conc"

strt = _get_value_from_ds_datavar(ds, "starting_conc", strt)
ic = flopy.mf6.ModflowGwtic(gwt, strt=strt, pname=pname, **kwargs)

return ic
Expand Down
Loading