Merged
Conversation
dbrakenhoff
approved these changes
May 1, 2025
Collaborator
dbrakenhoff
left a comment
dbrakenhoff
left a comment
There was a problem hiding this comment.
Nice, good solution for now I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom exception for KNMI data platform tests.
I tried playing around a bit with what kind of errors we generally get. Most common was the
KeyError: 'files'because the response contained:{'error': 'Rate limit exceeded'}. I now check if error in the response json and raise a custom error. In the tests this custom error is also allowed.