improve plot.data_array for structured grids#445
Merged
rubencalje merged 1 commit intodevfrom Apr 17, 2025
Merged
Conversation
dbrakenhoff
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves nlmod.plot.data_array for structured grids. This method did not show any data for grids with only one row or one column, as the column or row width could not be determined from only the x- or y coordinate. This is now fixed. This fix probably also improves accuracy of the plot when a varying delr and delc is used.
The user is required to supply the model dataset (ds) to use this fix.