Skip to content

Solve issue #442#443

Merged
dbrakenhoff merged 2 commits intodevfrom
fix_issue_442
Apr 15, 2025
Merged

Solve issue #442#443
dbrakenhoff merged 2 commits intodevfrom
fix_issue_442

Conversation

@rubencalje
Copy link
Collaborator

@rubencalje rubencalje commented Apr 15, 2025

Solves issue #442

Also, some automatic formatting of dcs.py and added a test for a 2d model

And change `assert ds.gridtype == "structured"` to `assert is_structured(ds)`
@rubencalje rubencalje requested a review from dbrakenhoff April 15, 2025 09:43
Copy link
Collaborator

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Todo to In Progress in NHFLO Apr 15, 2025
@dbrakenhoff dbrakenhoff merged commit 354f562 into dev Apr 15, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in NHFLO Apr 15, 2025
@dbrakenhoff dbrakenhoff deleted the fix_issue_442 branch April 15, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants