Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the slow test issue reported in #437 by modifying the time parameter for the test and updating documentation in the KNMI recharge module.
- Modified test_get_recharge_not_available() in tests to use a normalized current timestamp and a shifted start time.
- Updated the docstring and error handling in get_recharge() in nlmod/read/knmi.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_005_external_data.py | Changed time parameter to a normalized timestamp and shifted start date to speed up tests |
| nlmod/read/knmi.py | Revised docstring wording and added error handling for unexpected grid types |
Comments suppressed due to low confidence (2)
tests/test_005_external_data.py:44
- Verify that passing a list containing a single timestamp to set_ds_time is consistent with its expected API. If set_ds_time expects a pd.DatetimeIndex or a different time format, consider updating this accordingly.
time = [pd.Timestamp.now().normalize()]
nlmod/read/knmi.py:75
- [nitpick] Consider including the actual gridtype in the ValueError message to help with debugging, for example by using f'Unexpected gridtype: {ds.gridtype}. Expected "structured" or "vertex".'
else:
Collaborator
Author
|
This test will keep being super slow until we make a new release of hydropandas or force nlmod to use the dev version of hydropandas in its tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #437
Just realized, this change will only work if hydropandas is up to date 😇 . Maybe try to pick period with partially available data instead.