Skip to content

allow passing multiple lake observation types as a list of str #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrakenhoff merged 2 commits into from
Mar 14, 2025
Merged

allow passing multiple lake observation types as a list of str #415

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
989e945
allow passing multiple lake observation types as a list of str
dbrakenhoff Feb 28, 2025
4a58f1a
add docstring, add support for list of obs for LKT
dbrakenhoff Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nlmod/gwf/lake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,12 @@ def lake_from_gdf(
noutlets = len(outlets)

if boundname_column is not None:
obs_list = [(x, obs_type, x) for x in np.unique(gdf[boundname_column])]
observations = {f"{pname}_{obs_type}.csv": obs_list}
observations = {}
if isinstance(obs_type, str):
obs_type = [obs_type]
for otype in obs_type:
obs_list = [(x, otype, x) for x in np.unique(gdf[boundname_column])]
observations[f"{pname}_{otype}.csv"] = obs_list
else:
observations = None

Expand Down