Merged
Conversation
- define NLMOD_CACHE_OPTIONS - set defaults (identical to current caching defaults) - add context manager for cache options - add functions to set, get and reset options.
- add check for setting NLMOD_CACHING_OPTIONS - add logging when global config modifies default - do not check hashes if global option overrides cache decorator setting - add explicit dataset coordinate check, useful if hash checks are disabled.
OnnoEbbens
reviewed
Feb 26, 2025
OnnoEbbens
requested changes
Feb 26, 2025
Collaborator
OnnoEbbens
left a comment
There was a problem hiding this comment.
Just one comment and then you are good to go, should be an easy fix
Collaborator
Author
- use assert_identical - invalidate cache when explicit check fails
Collaborator
Author
|
I went for full debug level logging in the excplicit check. Also, I removed "area" from the data set variables in I think this is good to go now. |
bdestombe
requested changes
Feb 27, 2025
bdestombe
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This allows overriding caching behavior using
nlmod.config.NLMOD_CACHE_OPTIONS. This allows you to turn off the hash checks, and optionally activate an explicit dataset coordinate comparison. This allows some more flexibility when running into issue #389.Recommended usage:
add config submodule
in cache.py