Improve combine layers + some tiny fixes#410
Merged
OnnoEbbens merged 12 commits intodevfrom Feb 25, 2025
Merged
Conversation
- check if layers are consecutive and give a useful error message otherwise - deal with single layer entries (#406) - accept both string and layer index input in combine_layers as dictionary or list
dictionaries maintain order since python 3.6 i believe
subtract offset from one of the x-sec label locations
OnnoEbbens
requested changes
Feb 25, 2025
Collaborator
OnnoEbbens
left a comment
OnnoEbbens
left a comment
There was a problem hiding this comment.
Nice fixes! I think there is some inconsistency with removing the layer dimension from the top. It was already there before this PR. I think it is easily fixed, although it might break some old scripts.
- allow passing of str or xr.DataArray - default is "active_domain" - no warning is shown if it is not present in ds.
Co-authored-by: OnnoEbbens <[email protected]>
Co-authored-by: OnnoEbbens <[email protected]>
OnnoEbbens
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve combine_layers:
Other fixes: