Skip to content

Parsing of 'c' value as float instead of timedelta[ns] #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubencalje merged 5 commits into from
Jan 16, 2025
Merged

Parsing of 'c' value as float instead of timedelta[ns] #402

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d72fedc
Parsing of 'c' value as float instead of timedelta[ns]
MattBrst Jan 15, 2025
ba3de49
Incorporate suggestion from PR conversation
MattBrst Jan 15, 2025
b30865c
Set decode_times to False again in get_regis
rubencalje Jan 15, 2025
861d76f
Make get_regis more robust for user input of `variables`
rubencalje Jan 15, 2025
0084c80
Add tests for variables argument in get_regis
rubencalje Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions nlmod/read/regis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,11 @@ def get_regis(
variables = variables + ("sdh", "sdv")
ds = ds[list(variables)]

# the 'c' value is specified as a timedelta[ns] and should be converted to a float in days.
# this needs to be done before the NaN replacement of -9999 values.
if "c" in variables and ds["c"].dtype.type is np.timedelta64:
ds["c"] = ds["c"] / np.timedelta64(1, "D")

# since version REGIS v02r2s2 (22.07.2024) NaN values are replaced by -9999
# we set these values to NaN again
if nodata is not None:
Expand All @@ -198,6 +203,8 @@ def get_regis(
ds[datavar].attrs["units"] = "mNAP"
elif datavar in ["kh", "kv"]:
ds[datavar].attrs["units"] = "m/day"
elif datavar in ["c"]:
ds[datavar].attrs["units"] = "days"

# set the crs to dutch rd-coordinates
ds.rio.write_crs(28992, inplace=True)
Expand Down