Skip to content

Small improvements#378

Merged
dbrakenhoff merged 8 commits intodevfrom
small_improvements
Nov 7, 2024
Merged

Small improvements#378
dbrakenhoff merged 8 commits intodevfrom
small_improvements

Conversation

@dbrakenhoff
Copy link
Collaborator

  • Load ds from binary model grid (e.g. model.disv.grb file)
  • Improve pyproj CRS initialization
  • Add get_area() method using shoelace formula
  • allow plotting modelgrid with or without rotation.

to accept both ds.time and ds
@rubencalje
Copy link
Collaborator

Looks good. Would add_area_to_ds not be a better method name, instead of get_area?

@OnnoEbbens
Copy link
Collaborator

I think it is better to return the area and not add the area to the dataset. Like we do in get_idomain. Also discussed in this issue #254

@dbrakenhoff dbrakenhoff merged commit df4c918 into dev Nov 7, 2024
@dbrakenhoff dbrakenhoff deleted the small_improvements branch November 7, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants