add get_isosurface and get_isosurface_1d#376
Merged
dbrakenhoff merged 2 commits intodevfrom Oct 21, 2024
Merged
Conversation
Collaborator
dbrakenhoff
commented
Oct 9, 2024
dbrakenhoff
commented
- compute isosurface, e.g. depth at which concentration exceeds a threshold value.
- compute isosurface, e.g. depth at which concentration exceeds a threshold value.
rubencalje
approved these changes
Oct 21, 2024
Collaborator
rubencalje
left a comment
rubencalje
left a comment
There was a problem hiding this comment.
I approve, but have some questions which could be answered in the docstring of get_isosurface:
1 WIll this work for vertex grids as well?
2 Can we use other interpolation techniques than linear?
3 What do the kwargs do in get_isosurface?
- address comments @rubencalje - add test
Collaborator
Author
|
I improved the docstring, and made some improvements. Test fail unrelated to this PR. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.