Conversation
|
Test fails unrelated. |
OnnoEbbens
left a comment
There was a problem hiding this comment.
Nice addition. There are already two functions in nlmod.util to create a polygon from the extent polygon_from_extent and to create a geodataframe from an extent gdf_from_extent. I think these functions are nice to keep and the plot function can call them. Only thing is that we should move them somewhere else because 'util' is not the best place. Probably the resample module is a good place because get_extent is also in there.
It is even worse... We also have |
I moved some of the methods from the resample-module to the grid-module (also see the starting-message of this PR). I also moved All the old methods continue to work for now, and the user will get to see a deprecation-message. |
OnnoEbbens
left a comment
There was a problem hiding this comment.
Compliments for all the proper deprecations. I just have some minor comments.
|
Test fails are unrelated to the last commit. Maybe something to do with the new KNMI stations containing old data? One of the examples is looking for precipitation data from 1893... Merging this PR, if we need some more fixes, we'll figure that out for the new release PR I'll open shortly. |
This PR is originally made by @dbrakenhoff to add a modelextent-plot.
It has been misused by me (@rubencalje) to replace some of the methods from the resample-module to the grid-module. For example the
nlmod.resample.get_extent(ds)now isnlmod.grid.get_extent(ds), which I think is more logical. The original methods still function, and the user will see a warning that the old methods are deprecated.