Skip to content

Patch auto-download executables#354

Merged
bdestombe merged 8 commits intodevfrom
mf6-auto-download-patch
Jun 27, 2024
Merged

Patch auto-download executables#354
bdestombe merged 8 commits intodevfrom
mf6-auto-download-patch

Conversation

@bdestombe
Copy link
Collaborator

@bdestombe bdestombe commented Jun 24, 2024

  • download_mfbinaries() should not retreive any None values for version_tags. Which was the case if: no mf6 was ever downloaded on your system and no version_tag was specified in get_bin_directory() or to_model_ds() .
  • Remove explicit download commands and rely on auto download of executables. Closes Remove explicit download of executables command from examples #348

@bdestombe
Copy link
Collaborator Author

bdestombe commented Jun 24, 2024

Uhhg. They have built a nasty conditional statement in flopy that detects testing environment and in case of testing don't write the metadata. The written metadata is needed later for locating installs. https://github.com/modflowpy/flopy/blob/0748dcb9e4641b5ad9616af115dd3be906f98f50/flopy/utils/get_modflow.py#L623

A bit like the Volkswagen/audi/diesel gate that detected when the cars were tested for emissions. During testing conditions they would emit less..

@bdestombe bdestombe merged commit f70f100 into dev Jun 27, 2024
@bdestombe bdestombe deleted the mf6-auto-download-patch branch June 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove explicit download of executables command from examples

2 participants