Skip to content

Animate cross section#351

Merged
OnnoEbbens merged 5 commits intodevfrom
animate_cross_section
Jun 17, 2024
Merged

Animate cross section#351
OnnoEbbens merged 5 commits intodevfrom
animate_cross_section

Conversation

@OnnoEbbens
Copy link
Collaborator

Add method to animate a cross section

@OnnoEbbens OnnoEbbens requested a review from rubencalje June 10, 2024 14:20
Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some items could be made optional, like the colorbar and the title, but that can also be changed later.

It would be great if you can add a small test.

@OnnoEbbens
Copy link
Collaborator Author

Ik zal een voorbeeld toevoegen aan een notebook omdat ik dan alle data heb om een animatie te maken. Ik probeerde dit net maar het lijkt alsof de regis netcdf (tijdelijk) offline is. Ik krijg deze error:

OSError: [Errno -68] NetCDF: I/O failure: b'[http://www.dinodata.nl:80/opendap/REGIS/REGIS.nc](http://www.dinodata.nl/opendap/REGIS/REGIS.nc)'

@OnnoEbbens
Copy link
Collaborator Author

It seems like the old URL works again: https://www.dinodata.nl/opendap/hyrax/REGIS/REGIS.nc

@OnnoEbbens
Copy link
Collaborator Author

I have the feeling that the appropriate URL depends on the package versions I am using. So I did not change anything there

@rubencalje
Copy link
Collaborator

I have the feeling that the appropriate URL depends on the package versions I am using. So I did not change anything there

Strange that it is working in your latest commit, but not in other pull requests after that....

@OnnoEbbens OnnoEbbens merged commit 8fb859b into dev Jun 17, 2024
@OnnoEbbens OnnoEbbens deleted the animate_cross_section branch June 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants