Skip to content

Comparison with NaN does not work as expected #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasleplus wants to merge 1 commit into
base: 3.0.0
Choose a base branch
from
Open

Comparison with NaN does not work as expected #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/net/librec/math/structure/VectorBasedSequentialSparseVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public VectorBasedSequentialSparseVector(Vector other) {
List<Double> nonZeros = new ArrayList<Double>();
for (VectorEntry e : other) {
double value = e.get();
if (value != 0d && value != Double.NaN) {
if (value != 0d && !Double.isNaN(value)) {
nonZeros.add(value);
}
}
Expand Down Expand Up @@ -93,7 +93,7 @@ private OrderedIntDoubleMapping copySortedRandomAccessSparseVector(Vector other)
// get nonZero values
for (VectorEntry vectorEntry : other) {
double value = vectorEntry.get();
if (value != 0d && value != Double.NaN) {
if (value != 0d && !Double.isNaN(value)) {
sortableEntries[elementIndex++] = new OrderedVectorElement(vectorEntry.index(), value);
}
}
Expand Down