Correctly handle the exclamation mark at the beginning of the pattern#26
Conversation
|
Wow! Looks like CI is broken and it is not related to my changes. Travis — ok |
52151de to
a50efe6
Compare
|
Thanks @mrmlnc! I'll get the flakey CI fixed and release this. By the way, how's fast-glob doing? I am considering it for the next major revision of gulp since we've had so many issues with node-glob. |
|
Figured it out, the new npm broke scripts on windows for some reason. Patched the appveyor CI config to get it to pass. I'll rebase this in. Thanks again. |
|
Published! Thanks again, and if you have a chance, I'd love to hear about fast-glob :) |
Basically, all the «basic» scenarios work successfully (already tested by globby, parcel, prettier, nestjs, stylelint, relay, …). Sometimes there are problems with edge cases. If you have any questions, I would be happy to answer them. However, we have a several problems which users notice after switching from
Just some links:
JFYI: isaacs/node-glob#405 |
What is the purpose of this pull request?
This is a fix for mrmlnc/fast-glob#261.
What changes did you make? (Give an overview)
If the pattern has an exclamation mark with escaping at the beginning of the pattern, the base directory is proposed incorrectly.