Ensure we only free the context when allocated#113
Merged
Conversation
Let the application deal with deleting the context if it passed us a valid one, this allows it to still extract some data from the contexrt, if needed, even on error, and the delete it. If the function just created the context free it, as we do not want to return a potentially incomplete context on error. Signed-off-by: Simo Sorce <simo@redhat.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the application deal with deleting the context if it passed us a valid one, this allows it to still extract some data from the contexrt, if needed, even on error, and the delete it.
If the function just created the context free it, as we do not want to return a potentially incomplete context on error.