Skip to content

Detect strerror_r return type at configure time#110

Merged
simo5 merged 1 commit into
gssapi:mainfrom
AlmostArtificial:fix-musl-support
Jan 26, 2026
Merged

Detect strerror_r return type at configure time#110
simo5 merged 1 commit into
gssapi:mainfrom
AlmostArtificial:fix-musl-support

Conversation

@AlmostArtificial

Copy link
Copy Markdown

Summary

  • Use Autoconf’s AC_FUNC_STRERROR_R to determine whether strerror_r returns char * or int
  • Switch gss_err.c to branch on STRERROR_R_CHAR_P for correct behavior on both glibc and musl
  • Build now succeeds on Alpine/musl (fixes the strerror_r return-type compile error)

AI Usage

This PR was prepared with assistance from an AI agent.

@simo5

simo5 commented Jan 26, 2026

Copy link
Copy Markdown
Member

@AlmostArtificial Can you rebase on main so we can run the tests?

Use AC_FUNC_STRERROR_R and switch gss_err.c to STRERROR_R_CHAR_P so
GNU vs XSI variants are handled correctly across glibc and musl.

Signed-off-by: Almost Artificial <zogyyy2@hotmail.com>
@AlmostArtificial

Copy link
Copy Markdown
Author

@simo5 done

@simo5 simo5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
LGTM!

@simo5 simo5 merged commit 1d32d3e into gssapi:main Jan 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants