Skip to content

Add a 'disableGlobal' option #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodgarcia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a 'disableGlobal' option #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5322b0
Add an option to prevent the templates to be added to the global name…
rodgarcia Mar 25, 2016
d49cc85
Fix code style
rodgarcia Mar 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tasks/handlebars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ module.exports = function(grunt) {
// nsdeclare options when fetching namespace info
var nsDeclareOptions = {response: 'details', declared: nsDeclarations};

// if 'disableGlobal' option is true prevent the templates to be declared in the global namespace
if (options.disableGlobal) {
nsDeclareOptions.root = 'templates';
}

// Just get the namespace info for a given template
var getNamespaceInfo = _.memoize(function(filepath) {
if (!useNamespace) {
Expand Down Expand Up @@ -182,7 +187,11 @@ module.exports = function(grunt) {

output.push(nodeExport);
}
}

// if the 'disableGlobal' option is true create a local root variable to contain the templates
if (options.disableGlobal) {
output.unshift('var ' + nsDeclareOptions.root + ' = {};');
}

if (options.amd) {
Expand Down