Skip to content

Conversation

@KOLANICH
Copy link

Added pyproject.toml
Version is now populated automatically from git using setuptools_scm.

I had to remove everything from meta except the version (it can be fetched and populated, but it will slow down loading the module and I really doubt anyone ever relied on this API) and also removed the very suspicious exec call that has no legit reason to be present in this lib.

@KOLANICH KOLANICH force-pushed the setup.cfg branch 2 times, most recently from 4094e05 to ab76eb2 Compare February 22, 2022 16:54
@alexmojaki
Copy link
Collaborator

+1 for removing exec, see #87

I quite like the setup in my own packages like https://github.com/alexmojaki/executing which was also initially introduced by @KOLANICH. It's minimal and very standard, see e.g. setup.py. @gruns are you attached to the commands in your setup.py? For publishing I use https://github.com/alexmojaki/executing/blob/master/make_release.sh. Is being able to run python setup.py test important?

@KOLANICH
Copy link
Author

@alexmojaki, BTW you should be able to remove setup.py completely since modern versions of pip support editable install in this case. I also think that we should get rid of setup.py here too.

Version is now populated automatically from git using `setuptools_scm`.
@Jakeroid
Copy link
Collaborator

@KOLANICH

Thank you for any support from your side. Do you think it would be possible to resolve conflicts and prepare a PR to move forward in a future without setup.cfg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants