A69: Certificate Revocation List Enhancements #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erm-g
suggested changes
Jul 26, 2023
Contributor
erm-g
left a comment
erm-g
left a comment
There was a problem hiding this comment.
looks good, suggested a bunch of changes related to wording / moving statements around
gtcooke94
changed the title
ejona86
approved these changes
Sep 29, 2023
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
A few more comments on top of @erm-g's. But looks good.
@markdroth, @dfawley, can y'all take a look?
gtcooke94
added a commit
to grpc/grpc
that referenced
this pull request
Oct 17, 2023
The basic APIs for the CRL Reloading features. This adds external types to represent CRL Providers, CRLs, and CertificateInfo. Internally we will use `CrlImpl` - this layer is needed to hide OpenSSL details from the user. GRFC - grpc/proposal#382 Things Done * Add external API for `CrlProvider`, `Crl`, `CertInfo` (`CertInfo` is used during CRL lookup rather than passing the entire certificate). * Add code paths in `ssl_transport_security` to utilize CRL providers * Add `StaticCrlProvider` * Refactor `crl_ssl_transport_security_test.cc` so it is more extensible and can be used with providers
erm-g
reviewed
Nov 2, 2023
erm-g
reviewed
Nov 2, 2023
erm-g
reviewed
Nov 2, 2023
gtcooke94
added a commit
to grpc/grpc
that referenced
this pull request
Nov 3, 2023
This adds the directory reloader implementation of the CrlProvider. This will periodically reload CRL files in a directory per [gRFC A69](grpc/proposal#382) Included in this is the following: * A public API to create the `DirectoryReloaderCrlProvider` * A basic directory interface in gprpp and platform specific impls for getting the list of files in a directory (unfortunately prior C++17, there is no std::filesystem, so we have to have platform specific impls) * The implementation of `DirectoryReloaderCrlProvider` takes an event_engine and a directory interface. This allows us to test using the fuzzing event engine for time mocking, and to implement a test directory interface so we avoid having to make temporary directories and files in the tests. This is notably not in `include`, and the `CreateDirectoryReloaderCrlProvider` is the only way to construct one from the public API, so we don't expose the event engine and directory details to the user. --------- Co-authored-by: gtcooke94 <[email protected]>
gtcooke94
added a commit
to gtcooke94/grpc
that referenced
this pull request
Nov 13, 2023
) This adds the directory reloader implementation of the CrlProvider. This will periodically reload CRL files in a directory per [gRFC A69](grpc/proposal#382) Included in this is the following: * A public API to create the `DirectoryReloaderCrlProvider` * A basic directory interface in gprpp and platform specific impls for getting the list of files in a directory (unfortunately prior C++17, there is no std::filesystem, so we have to have platform specific impls) * The implementation of `DirectoryReloaderCrlProvider` takes an event_engine and a directory interface. This allows us to test using the fuzzing event engine for time mocking, and to implement a test directory interface so we avoid having to make temporary directories and files in the tests. This is notably not in `include`, and the `CreateDirectoryReloaderCrlProvider` is the only way to construct one from the public API, so we don't expose the event engine and directory details to the user. --------- Co-authored-by: gtcooke94 <[email protected]>
gtcooke94
added a commit
to gtcooke94/grpc
that referenced
this pull request
Nov 13, 2023
) This adds the directory reloader implementation of the CrlProvider. This will periodically reload CRL files in a directory per [gRFC A69](grpc/proposal#382) Included in this is the following: * A public API to create the `DirectoryReloaderCrlProvider` * A basic directory interface in gprpp and platform specific impls for getting the list of files in a directory (unfortunately prior C++17, there is no std::filesystem, so we have to have platform specific impls) * The implementation of `DirectoryReloaderCrlProvider` takes an event_engine and a directory interface. This allows us to test using the fuzzing event engine for time mocking, and to implement a test directory interface so we avoid having to make temporary directories and files in the tests. This is notably not in `include`, and the `CreateDirectoryReloaderCrlProvider` is the only way to construct one from the public API, so we don't expose the event engine and directory details to the user. --------- Co-authored-by: gtcooke94 <[email protected]>
ejona86
approved these changes
Nov 20, 2023
markdroth
reviewed
Nov 27, 2023
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
The overall design looks good! My comments here are mostly just details that need to be spelled out a little more clearly.
Please let me know if you have any questions. Thanks!
markdroth
approved these changes
Jan 31, 2025
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
This looks good! Remaining comments are just minor wording suggestions.
dfawley
approved these changes
Feb 28, 2025
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
Some formatting things otherwise LGTM!
Co-authored-by: Doug Fawley <[email protected]>
Co-authored-by: Doug Fawley <[email protected]>
Co-authored-by: Doug Fawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.