A39 update: Add support for terminal filters. #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
changed the title
dfawley
approved these changes
Jul 21, 2021
ejona86
added a commit
to ejona86/proposal
that referenced
this pull request
Jul 21, 2021
This is to match Envoy's handling. See also grpc#250 for the http filter change.
ejona86
added a commit
to ejona86/proposal
that referenced
this pull request
Jul 21, 2021
This is to match Envoy's handling. See also grpc#250 for the http filter change.
ejona86
reviewed
Jul 21, 2021
ejona86
approved these changes
Jul 21, 2021
ejona86
added a commit
that referenced
this pull request
Jul 21, 2021
This is to match Envoy's handling. See also #250 for the http filter change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches Envoy's handling, removes special-case handling that we had for the router filter, and allows us to catch more problems at config validation time.
C-core implementation in grpc/grpc#26742.