Skip to content

Upgrade proto-google-common-protos to 1.17.0 #6572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ran-su merged 1 commit into from
Dec 27, 2019
Merged

Upgrade proto-google-common-protos to 1.17.0 #6572

ran-su merged 1 commit into from
Dec 27, 2019

Conversation

@suztomo
Copy link
Contributor

@suztomo suztomo commented Dec 26, 2019

Grpc-java's proto-google-common-protos dependency is outdated. Upgrading to the latest version.

Motivation of this upgrade is below:

io.grpc:grpc-protobuf:1.25.0 x com.google.cloud:google-cloud-bigquerystorage:0.120.0-beta

Class com.google.api.ClientProto is not found (type: CLASS_NOT_FOUND)
  com.google.cloud.bigquery.storage.v1beta1.Storage (com.google.api.grpc:proto-google-cloud-bigquerystorage-v1beta1:0.85.0)
Class com.google.api.FieldBehaviorProto is not found (type: CLASS_NOT_FOUND)
  com.google.cloud.bigquery.storage.v1beta1.Storage (com.google.api.grpc:proto-google-cloud-bigquerystorage-v1beta1:0.85.0)
Class com.google.api.ResourceProto is not found (type: CLASS_NOT_FOUND)
  com.google.cloud.bigquery.storage.v1beta1.Storage (com.google.api.grpc:proto-google-cloud-bigquerystorage-v1beta1:0.85.0)
com.google.cloud.bigquery.storage.v1beta1.TableReferenceProto (com.google.api.grpc:proto-google-cloud-bigquerystorage-v1beta1:0.85.0)

Old proto-google-common-protos does not have the classes noted above.

suztomo
suztomo commented Dec 26, 2019
View reviewed changes
repositories.bzl
artifact = "com.google.api.grpc:proto-google-common-protos:1.17.0",
server_urls = ["https://repo.maven.apache.org/maven2/"],
artifact_sha256 = "bd60cd7a423b00fb824c27bdd0293aaf4781be1daba6ed256311103fb4b84108",
artifact_sha256 = "ad25472c73ee470606fb500b376ae5a97973d5406c2f5c3b7d07fb25b4648b65",
Copy link
Contributor Author

@suztomo suztomo Dec 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

suztomo@suxtomo24:~/grpc-java$ shasum -a 256 ~/Downloads/proto-google-common-protos-1.17.0.jar 
ad25472c73ee470606fb500b376ae5a97973d5406c2f5c3b7d07fb25b4648b65  /usr/local/google/home/suztomo/Downloads/proto-google-common-protos-1.17.0.jar

@ran-su ran-su added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 26, 2019
creamsoup
creamsoup approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ran-su
ran-su approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@ran-su ran-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-su ran-su merged commit f07b79b into grpc:master Dec 27, 2019
@ran-su
Copy link
Member

ran-su commented Dec 27, 2019

@suztomo merged. Thanks

@suztomo
Copy link
Contributor Author

suztomo commented Dec 27, 2019

Thank you

@suztomo suztomo deleted the commons-protos-1.17 branch December 27, 2019 20:59
@ejona86 ejona86 mentioned this pull request Dec 30, 2019
Merged
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Dec 30, 2019
@ejona86
Match version of proto-google-common-protos changed in grpc#6572
0055c0b
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ran-su ran-su ran-su approved these changes

+1 more reviewer

@creamsoup creamsoup creamsoup approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-su ran-su

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @ran-su @creamsoup @grpc-kokoro