grpclb: support explicit fallback from LB #6549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Dec 19, 2019
| if (typeCase != LoadBalanceResponseTypeCase.SERVER_LIST) { | ||
| if (typeCase == LoadBalanceResponseTypeCase.FALLBACK_RESPONSE) { | ||
| useFallbackBackends(); | ||
| maybeUpdatePicker(); |
Contributor
There was a problem hiding this comment.
Do you want to call cancelFallbackTimer()?
| verify(subchannelPool) | ||
| .returnSubchannel(eq(subchannel2), eq(ConnectivityStateInfo.forNonError(READY))); | ||
|
|
||
| // verify fallback (no backends) |
Contributor
There was a problem hiding this comment.
The more common case is that there are fallback backends.
zhangkun83
approved these changes
Dec 20, 2019
Contributor
Author
|
although this change is backward compatible, waiting for the proto to be published. |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Feb 10, 2020
This noticed that load_balancer.proto had local changes introduced in grpc#6549. This was not noticed by Bazel because grpclb was not using the io_grpc_grpc_proto repository. These issues have been fixed.
ejona86
added a commit
that referenced
this pull request
Feb 10, 2020
This noticed that load_balancer.proto had local changes introduced in #6549. This was not noticed by Bazel because grpclb was not using the io_grpc_grpc_proto repository. These issues have been fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, the proto is not updated yet.