Skip to content

Replaced outdated exclusion comments #6492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
creamsoup merged 2 commits into from
Dec 5, 2019
Merged

Replaced outdated exclusion comments #6492

creamsoup merged 2 commits into from
Dec 5, 2019

Conversation

@suztomo
Copy link
Contributor

@suztomo suztomo commented Dec 5, 2019

Followup of #6488 (comment). These comments on exclusions with specific versions are hard to maintain.

@suztomo suztomo mentioned this pull request Dec 5, 2019
Merged
@suztomo
Copy link
Contributor Author

suztomo commented Dec 5, 2019

@creamsoup Would you check this too?

@ericgribkoff ericgribkoff added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@suztomo suztomo force-pushed the exclusion_comment_cleanup branch from aa36613 to 937107b Compare December 5, 2019 20:41
@creamsoup creamsoup added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@suztomo
Copy link
Contributor Author

suztomo commented Dec 5, 2019

??? https://source.cloud.google.com/results/invocations/3ad5cb7c-c2d8-49e4-82ce-5db7dde4c2b6/log

> Task :grpc-interop-testing:test

io.grpc.testing.integration.NettyFlowControlTest > largeBdp FAILED
    java.lang.AssertionError: Window was 688124 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
        at io.grpc.testing.integration.NettyFlowControlTest.largeBdp(NettyFlowControlTest.java:106)

@creamsoup
Copy link
Contributor

creamsoup commented Dec 5, 2019

that's a known flaky test, i logged this in the existing issue.

@suztomo
Copy link
Contributor Author

suztomo commented Dec 5, 2019

Okay. Thanks. Then it's ready for merge.

@creamsoup
Copy link
Contributor

creamsoup commented Dec 5, 2019

kokoro is extra flaky today, as soon as all the required checks are finished. i'll merge it.

@creamsoup creamsoup added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 5, 2019
@creamsoup creamsoup merged commit 2963878 into grpc:master Dec 5, 2019
@creamsoup
Copy link
Contributor

creamsoup commented Dec 5, 2019

merged! thanks again @suztomo

@suztomo
Copy link
Contributor Author

suztomo commented Dec 5, 2019

Thank you.

@suztomo suztomo deleted the exclusion_comment_cleanup branch December 5, 2019 22:32
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@creamsoup creamsoup creamsoup approved these changes

@ericgribkoff ericgribkoff ericgribkoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @creamsoup @ericgribkoff @grpc-kokoro