Context.Storage deprecated method attach() removed, doAttach() made abstract #10379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-safran
approved these changes
Jul 13, 2023
tonyjongyoonan
requested review from
sergiitk
and removed request for
YifeiZhuang and
ejona86
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2462 contains the discussion about the
attach(Context)method.The
doAttach(Context)method has been made abstract and theattach(Context)method has been deleted.There are no open-source or g3 dependencies for this method.
There is only one affected repo from this query, which shouldn't block us from making this change.