Skip to content

xds: allow empty nodeID in bootstrap configuration #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

xds: allow empty nodeID in bootstrap configuration #8476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions xds/internal/clients/xdsclient/xdsclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ type XDSClient struct {
// New returns a new xDS Client configured with the provided config.
func New(config Config) (*XDSClient, error) {
switch {
case config.Node.ID == "":
return nil, errors.New("xdsclient: node ID is empty")
case config.ResourceTypes == nil:
return nil, errors.New("xdsclient: resource types map is nil")
case config.TransportBuilder == nil:
Expand Down
15 changes: 10 additions & 5 deletions xds/internal/clients/xdsclient/xdsclient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ func (s) TestXDSClient_New(t *testing.T) {
config Config
wantErr string
}{
{
name: "empty node ID",
config: Config{},
wantErr: "node ID is empty",
},
{
name: "nil resource types",
config: Config{
Expand Down Expand Up @@ -75,6 +70,16 @@ func (s) TestXDSClient_New(t *testing.T) {
},
wantErr: "",
},
{
name: "success with servers and empty nodeID",
config: Config{
Node: clients.Node{ID: ""},
ResourceTypes: map[string]ResourceType{xdsresource.V3ListenerURL: listenerType},
TransportBuilder: grpctransport.NewBuilder(configs),
Servers: []ServerConfig{{ServerIdentifier: clients.ServerIdentifier{ServerURI: "dummy-server"}}},
},
wantErr: "",
},
{
name: "success with authorities",
config: Config{
Expand Down
Loading