Skip to content

Conversation

@arjan-bal
Copy link
Contributor

These changes are causing integration issues with an internal cipher implementation, see cl/745109957. The changes will be rolled forward when the cipher implementation is fixed.

RELEASE NOTES: N/A

@arjan-bal arjan-bal changed the title Rollback #8232 and #8204) Rollback #8232 and #8204 Apr 8, 2025
@arjan-bal arjan-bal added this to the 1.73 Release milestone Apr 8, 2025
@arjan-bal arjan-bal requested a review from easwars April 8, 2025 13:23
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (25c7509) to head (be7fef4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8236      +/-   ##
==========================================
+ Coverage   82.06%   82.13%   +0.07%     
==========================================
  Files         412      412              
  Lines       40503    40491      -12     
==========================================
+ Hits        33238    33257      +19     
+ Misses       5892     5866      -26     
+ Partials     1373     1368       -5     
Files with missing lines Coverage Δ
credentials/alts/internal/conn/common.go 100.00% <100.00%> (ø)
credentials/alts/internal/conn/record.go 82.55% <100.00%> (+4.34%) ⬆️
credentials/alts/internal/handshaker/handshaker.go 69.58% <100.00%> (-6.19%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars assigned arjan-bal and unassigned easwars Apr 8, 2025
@arjan-bal arjan-bal merged commit 6bfa0ca into grpc:master Apr 8, 2025
15 checks passed
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Apr 13, 2025
* Revert "credentials/alts: Add comments to clarify buffer sizing (grpc#8232)"

This reverts commit be25d96.

* Revert "credentials/alts: Optimize reads (grpc#8204)"

This reverts commit b368379.
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
* Revert "credentials/alts: Add comments to clarify buffer sizing (grpc#8232)"

This reverts commit be25d96.

* Revert "credentials/alts: Optimize reads (grpc#8204)"

This reverts commit b368379.
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request May 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants