Skip to content

benchmark: Specify passthrough resolver to avoid resolution failures#8231

Merged
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:fix-benchmark
Apr 8, 2025
Merged

benchmark: Specify passthrough resolver to avoid resolution failures#8231
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:fix-benchmark

Conversation

@arjan-bal
Copy link
Copy Markdown
Contributor

In #7970, the benchmarking code was changed to use NewClient instead of Dial to create channels. This changed the default resolver from passthrough to dns. The usage fixed in this PR depended on the custom dialer dialing a fixed address irrespective of the resolver. Since the target was empty, the DNS resolver produces an error and causing RPCs to fail.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added Type: Bug Area: Benchmarking Includes our benchmarking utility. labels Apr 7, 2025
@arjan-bal arjan-bal added this to the 1.73 Release milestone Apr 7, 2025
@arjan-bal arjan-bal requested a review from easwars April 7, 2025 14:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (b368379) to head (c1f81d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8231      +/-   ##
==========================================
+ Coverage   81.99%   82.18%   +0.18%     
==========================================
  Files         410      410              
  Lines       40389    40389              
==========================================
+ Hits        33116    33192      +76     
+ Misses       5893     5839      -54     
+ Partials     1380     1358      -22     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars assigned arjan-bal and unassigned easwars Apr 7, 2025
@arjan-bal arjan-bal merged commit db81a2c into grpc:master Apr 8, 2025
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Apr 13, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 6, 2025
@arjan-bal arjan-bal deleted the fix-benchmark branch January 15, 2026 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: Benchmarking Includes our benchmarking utility. Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants