Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jan 22, 2025

@arjan-bal arjan-bal added this to the 1.70 Release milestone Jan 22, 2025
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (54b3eb9) to head (5a06379).
Report is 1 commits behind head on v1.70.x.

Files with missing lines Patch % Lines
xds/internal/xdsclient/client_refcounted.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.70.x    #8028      +/-   ##
===========================================
+ Coverage    82.02%   82.17%   +0.15%     
===========================================
  Files          384      384              
  Lines        38706    38718      +12     
===========================================
+ Hits         31748    31817      +69     
+ Misses        5637     5590      -47     
+ Partials      1321     1311      -10     
Files with missing lines Coverage Δ
server.go 82.62% <100.00%> (+0.09%) ⬆️
xds/internal/xdsclient/client_refcounted.go 81.81% <87.50%> (-0.24%) ⬇️

... and 23 files with indirect coverage changes

@arjan-bal arjan-bal requested review from dfawley and easwars and removed request for dfawley January 22, 2025 18:12
@arjan-bal arjan-bal requested a review from dfawley January 22, 2025 18:12
@dfawley
Copy link
Member

dfawley commented Jan 22, 2025

Please remember to N/A the release notes from the original PRs so these don't appear in the 1.71 relnotes too.

@arjan-bal arjan-bal merged commit bf380de into grpc:v1.70.x Jan 22, 2025
15 checks passed
@arjan-bal arjan-bal deleted the cherrypick-7998-8011 branch January 22, 2025 18:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants