Skip to content

Conversation

@purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Oct 7, 2024

This PR reverts #7654 which attempted to:

  • Remove the use_generic_streams_experimental flag.
  • Make the use of generics mandatory for stream methods.

This revert is necessary because the previous changes caused compatibility issues with existing usages of client and server stream methods within internal google3.

We will revisit this change once the affected usages in google3 have been migrated.

RELEASE NOTES: None

@purnesh42H purnesh42H added the Type: Meta Github repo, process, etc label Oct 7, 2024
@purnesh42H purnesh42H added this to the 1.68 Release milestone Oct 7, 2024
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (e8a70c6) to head (24f11cd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7703      +/-   ##
==========================================
+ Coverage   81.84%   81.86%   +0.01%     
==========================================
  Files         361      361              
  Lines       27822    27822              
==========================================
+ Hits        22772    22776       +4     
+ Misses       3854     3851       -3     
+ Partials     1196     1195       -1     

see 15 files with indirect coverage changes

@dfawley dfawley merged commit ab5af45 into grpc:master Oct 7, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Meta Github repo, process, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants