vet : add check for tabs in text files

[eshitachandwani]

• Added check for tabs in text files
• Replaced tabs with spaces in the following file :
  • Documentation/benchmark.md

RELEASE NOTES: None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (941102b) to head (3d1fb1a).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7678      +/-   ##
==========================================
- Coverage   82.01%   81.86%   -0.16%     
==========================================
  Files         361      361              
  Lines       27829    27822       -7     
==========================================
- Hits        22825    22777      -48     
- Misses       3821     3850      +29     
- Partials     1183     1195      +12     

see 33 files with indirect coverage changes

[purnesh42H]

shouldn't we be echoing only for failures?

[purnesh42H]

this might be enough not git grep $'\t' -- '*.md' because command and comment is self explanatory

[eshitachandwani]

Done

[dfawley]

Why pipe to fail_on_output? Inverting the result of grep should be sufficient? I.e. grep exits with 0 if there is a match and 1 if there is not.

[eshitachandwani]

Done

[purnesh42H]

lgtm

[easwars]

Can/Should we do this for all files?

[purnesh42H]

do you mean prohibit tab code files? I think the IDE might be doing that already.

[easwars]

I could be using an editor that doesn't do that. But looks like gofmt uses tabs for indentation. See: https://pkg.go.dev/cmd/gofmt. And we run gofmt in our vet script. So, we should be good.

[dfawley]

Go pretty famously uses tabs instead of spaces. Limiting to *.md SGTM.