Skip to content

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Aug 1, 2024

The balancergroup was initially implemented inside the priority LB policy, before being moved out to be a separate utility. Mentions of locality are from that day and age.

RELEASE NOTES: none

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Aug 1, 2024
@easwars easwars added this to the 1.66 Release milestone Aug 1, 2024
@codecov
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.42%. Comparing base (887d908) to head (a623b7a).

Files Patch % Lines
internal/balancergroup/balancergroup.go 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7476      +/-   ##
==========================================
- Coverage   81.53%   81.42%   -0.12%     
==========================================
  Files         357      357              
  Lines       27242    27242              
==========================================
- Hits        22213    22183      -30     
- Misses       3827     3846      +19     
- Partials     1202     1213      +11     
Files Coverage Δ
internal/balancergroup/balancergroup.go 79.81% <50.00%> (-1.41%) ⬇️

... and 16 files with indirect coverage changes

@dfawley dfawley requested a review from zasweq August 6, 2024 16:31
@zasweq zasweq assigned easwars and unassigned zasweq Aug 6, 2024
@easwars easwars merged commit 338595c into grpc:master Aug 6, 2024
1 check passed
@easwars easwars deleted the bg_cleanup branch August 6, 2024 17:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants