Skip to content

Conversation

@mkruskal-google
Copy link
Contributor

@mkruskal-google mkruskal-google commented Jun 25, 2024

Fixes #7067

None of the edition 2023 features affect grpc, and go-protobuf already supports editions

RELEASE NOTES: n/a

@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (1811c6f) to head (b6e2e52).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7351      +/-   ##
==========================================
- Coverage   81.40%   81.39%   -0.02%     
==========================================
  Files         348      348              
  Lines       26761    26761              
==========================================
- Hits        21786    21783       -3     
- Misses       3782     3786       +4     
+ Partials     1193     1192       -1     

see 17 files with indirect coverage changes

@dfawley dfawley added the Type: Feature New features or improvements in behavior label Jun 25, 2024
@dfawley dfawley added this to the 1.66 Release milestone Jun 25, 2024
dfawley
dfawley previously approved these changes Jun 25, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This LGTM. Note that "RELEASE NOTES" is our auto-generated grpc library release notes, and we release protoc-gen-go-grpc separately, so I removed them from your comment.

@dfawley dfawley changed the title Enable edition 2023 support cmd/protoc-gen-go-grpc: enable edition 2023 support Jun 25, 2024
@dfawley
Copy link
Member

dfawley commented Jun 25, 2024

Sorry, one request: could you add the "edition" tag to examples/route_guide/routeguide/route_guide.proto which will confirm this works as intended? You may need to regenerate the protos if you do that by running scripts/regenerate.sh.

@dfawley dfawley self-requested a review June 25, 2024 21:21
@dfawley dfawley dismissed their stale review June 25, 2024 21:21

Testing

@mkruskal-google
Copy link
Contributor Author

Sure np, I had to update the protoc version you're testing with too. But as expected, no meaningful differences to gencode

@dfawley dfawley merged commit 98e5dee into grpc:master Jun 26, 2024
1 check passed
@mkruskal-google mkruskal-google deleted the editions branch June 26, 2024 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protoc-gen-go-grpc: support proto edition

2 participants