vet: remove --quiet from git grep when output is expected #7305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass --quiet to git grep in places where we re-grep the output, which never yields any result because --quiet suppresses all output from stdout, even when -l is passed. Remove --quiet from all grep in vet
atollena
added
Type: Internal Cleanup
arvindbr8
approved these changes
Jun 6, 2024
Contributor
arvindbr8
left a comment
arvindbr8
left a comment
There was a problem hiding this comment.
You are right. errr, the change I added the --quiet in -- I remember I was tackling another problem. But everytime I run vet in Darwin it keeps hanging in an editor window when executing the git grep command.
My bad. Approved.
Collaborator
Author
Hmm. fwiw I also use Darwin, if you run into issues we can try to collaborate on them. |
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass
--quietto git grep in places where we re-grep the output, which never yields any result because--quietsuppresses all output from stdout, even when -l is passed.Remove
--quietfrom all grep in vet.RELEASE NOTES: none