stats/opentelemetry: Add CSM Observability API #7277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
May 29, 2024
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
Looks pretty good - mostly just nits.
dfawley
approved these changes
May 29, 2024
| otelinternal "google.golang.org/grpc/stats/opentelemetry/internal" | ||
| ) | ||
|
|
||
| // EnableObservability sets up CSM EnableObservability for the binary globally. |
Member
There was a problem hiding this comment.
CSM EnableObservability? What's that?
Contributor
Author
There was a problem hiding this comment.
Lol it switched this docstring.
|
|
||
| // EnableObservability sets up CSM EnableObservability for the binary globally. | ||
| // | ||
| // The CSM Plugin Option is instantiated with local labels and metadata exchange |
Member
There was a problem hiding this comment.
The CSM Stats Plugin? Metrics exporter? ??? Let's not put "plugin option" in our docstrings, though, I think.
Contributor
Author
There was a problem hiding this comment.
Choose "Stats Plugin".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: N/A