Skip to content

Conversation

@holdno
Copy link
Contributor

@holdno holdno commented May 7, 2024

Fixes #7135

add user-friendly error message of LB policy update timed out.

refer to PR #7143

RELEASE NOTES: none

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making the change

@dfawley dfawley requested a review from easwars May 7, 2024 14:57
@dfawley dfawley added the Type: Feature New features or improvements in behavior label May 7, 2024
@dfawley dfawley added this to the 1.64 Release milestone May 7, 2024
@easwars easwars closed this May 7, 2024
@easwars easwars reopened this May 7, 2024
@dfawley dfawley changed the title add user-friendly error message of LB policy update timed out client: add user-friendly error message of LB policy update timed out May 7, 2024
@dfawley dfawley merged commit 0561c78 into grpc:master May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In picker logic(picker_wrapper.go), clearly understand the real reason for failures after a context.Error(timeout)

3 participants