Skip to content

Conversation

@hakusai22
Copy link
Contributor

@hakusai22 hakusai22 commented May 2, 2024

fix typo

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@dfawley
Copy link
Member

dfawley commented May 2, 2024

Thanks for the PR.

Please revert the generated code (*.pb.go) as those are just copied from the source .proto file. If you want to fix those, too, they are in http://github.com/grpc/grpc-proto.

Also, what tool are you using for this? We may want to add it to our presubmit checks.

@hakusai22
Copy link
Contributor Author

Thanks for the PR.

Please revert the generated code (*.pb.go) as those are just copied from the source .proto file. If you want to fix those, too, they are in http://github.com/grpc/grpc-proto.

Also, what tool are you using for this? We may want to add it to our presubmit checks.

done. Thanks for the reply, I am using this tool https://github.com/crate-ci/typos

@hakusai22 hakusai22 changed the title fix typo fix: typo May 2, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@dfawley dfawley changed the title fix: typo *: fix typos May 2, 2024
@dfawley dfawley added this to the 1.64 Release milestone May 2, 2024
@arvindbr8
Copy link
Contributor

Thanks. Very wholesome

@arvindbr8 arvindbr8 merged commit 273fe14 into grpc:master May 2, 2024
1 check passed
@hakusai22 hakusai22 deleted the fix_typo branch May 3, 2024 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Documentation Documentation or examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants